Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix lint-staged config #140

Merged
merged 1 commit into from
Apr 10, 2024
Merged

chore: fix lint-staged config #140

merged 1 commit into from
Apr 10, 2024
+7 −5

Conversation

danilo-moreira-brisa
Copy link
Contributor

@danilo-moreira-brisa danilo-moreira-brisa commented Apr 8, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated the lint-staged script for enhanced linting and testing before commits.

@danilo-moreira-brisa danilo-moreira-brisa self-assigned this Apr 8, 2024
@danilo-moreira-brisa danilo-moreira-brisa linked an issue Apr 8, 2024 that may be closed by this pull request
chore: husky should run tests when commiting #138
Closed
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 8, 2024 •
edited
Loading

Walkthrough

The recent update to our project primarily enhances the pre-commit hooks by expanding the lint-staged script. This improvement aims to ensure a more rigorous check on the code quality and adherence to standards by incorporating additional linting and testing commands. It's a proactive step towards maintaining code hygiene and reducing potential issues in the development phase.

Changes

File(s) Change Summary
package.json Updated lint-staged script with more lint and test commands

🐰✨
In the realm of code, where rabbits dare to tread,
A change was made, before the commit fled.
Linting and testing, now more robust,
Ensuring our code, in quality we trust.
So hop along, dear friends, let's make our mark,
With cleaner code, we'll light the dark. 🌟
🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 8, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 64b0015 and b3da66a.
Files selected for processing (1)
  • package.json (1 hunks)
Additional comments not posted (1)
package.json (1)

22-28: The updated lint-staged configuration enhances code quality by integrating linting, formatting, and testing into the pre-commit process. Consider adding --silent to the yarn test command to reduce noise in the pre-commit output, especially when tests pass without issues.

@danilo-moreira-brisa danilo-moreira-brisa merged commit 5d937f4 into main Apr 10, 2024
6 checks passed
@danilo-moreira-brisa danilo-moreira-brisa deleted the chore-husky-should-run-tests-when-commiting-138 branch April 10, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@allan-chagas-brisa allan-chagas-brisa allan-chagas-brisa approved these changes

@iurynogueira iurynogueira Awaiting requested review from iurynogueira

Assignees

@danilo-moreira-brisa danilo-moreira-brisa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: husky should run tests when commiting
2 participants
@danilo-moreira-brisa @allan-chagas-brisa